add Flush() to bypass waiting for the timer #110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gburt
commented
Mar 14, 2024
| /////////////////////////////////////////////////// | ||
| // Tests | ||
| /////////////////////////////////////////////////// | ||
| /* |
Contributor
Author
There was a problem hiding this comment.
apologies about this change, vim kept changing the comments to // //////... on save so I just gave up and changed it to this.
pavelnikolov
approved these changes
May 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
Flush()method to thedataloader.Interfacethat if called will immediately fetch the outstanding batch without waiting for the timer. Should let us lower the latency in situations where we know that no more keys are going to be loaded so there's no reason to keep waiting.